testcluster: avoid t.Fatal on goroutine #55550
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This change is |
knz
approved these changes
Oct 14, 2020
StartServer was using this odd pattern where it took both a `*testing.T` and returned an `error`. This method was then also called on a goroutine whenever `ParallelStart` was specified. I wasted quite a bit on these errors (things just hang, really hard to debug) so I cleaned this method up to always return an error. Release note: None
tbg
force-pushed
the
testserver-cleanup
branch
from
8d05f1c
to
d301427
Compare
|
bors r=knz |
|
Build succeeded: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
StartServer was using this odd pattern where it took both a
*testing.Tand returned an
error. This method was then also called on a goroutinewhenever
ParallelStartwas specified.I wasted quite a bit on these errors (things just hang, really hard to
debug) so I cleaned this method up to always return an error.
Release note: None