Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

builtins: add sha224 and sha384 functions #55720

Merged
merged 1 commit into from
Oct 21, 2020
Merged

builtins: add sha224 and sha384 functions #55720

merged 1 commit into from
Oct 21, 2020

Conversation

timgraham
Copy link
Contributor

Fixes #42450

Release note (sql change): Add sha224 and sha384 functions.

@cockroach-teamcity
Copy link
Member

cockroach-teamcity commented Oct 20, 2020 •
edited
Loading

CLA assistant check
All committers have signed the CLA.

@blathers-crl
Copy link

blathers-crl bot commented Oct 20, 2020

Thank you for contributing to CockroachDB. Please ensure you have followed the guidelines for creating a PR.

My owl senses detect your PR is good for review. Please keep an eye out for any test failures in CI.

I have added a few people who may be able to assist in reviewing:

🦉 Hoot! I am a Blathers, a bot for CockroachDB. My owner is otan.

@blathers-crl blathers-crl bot added O-community Originated from the community X-blathers-triaged blathers was able to find an owner labels Oct 20, 2020
@blathers-crl blathers-crl bot requested a review from rafiss October 20, 2020 00:11
@cockroach-teamcity
Copy link
Member

This change is Reviewable

@timgraham
builtins: add sha224 and sha384 functions
10eefe1 
Fixes cockroachdb#42450

Release note (sql change): Add sha224 and sha384 functions.
@blathers-crl
Copy link

blathers-crl bot commented Oct 20, 2020

Thank you for updating your pull request.

My owl senses detect your PR is good for review. Please keep an eye out for any test failures in CI.

🦉 Hoot! I am a Blathers, a bot for CockroachDB. My owner is otan.

rafiss
rafiss approved these changes Oct 21, 2020
View reviewed changes
Copy link
Collaborator

@rafiss rafiss left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thank you for this change!

@rafiss
Copy link
Collaborator

rafiss commented Oct 21, 2020

bors r=rafiss

@craig
Copy link
Contributor

craig bot commented Oct 21, 2020

Build succeeded:

@craig craig bot merged commit 5eba4d3 into cockroachdb:master Oct 21, 2020
@timgraham timgraham deleted the sha224_384 branch October 26, 2020 13:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rafiss rafiss rafiss approved these changes

Assignees
No one assigned
Labels
O-community Originated from the community X-blathers-triaged blathers was able to find an owner
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

sql: support sha224 and sha384 builtin functions
3 participants
@timgraham @cockroach-teamcity @rafiss