schemachange: refactor GC job code #55737
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This change is |
spaskob
force-pushed
the
sc-simplify-gc
branch
from
20ad8e6 to
02e50bc
Compare
pbardea
approved these changes
Oct 20, 2020
There was a problem hiding this comment.
Reviewable status:
complete! 0 of 0 LGTMs obtained (waiting on @lucy-zhang, @pbardea, and @spaskob)
pkg/sql/gcjob/gc_job.go, line 153 at r1 (raw file):
persistProgress(ctx, execCfg, r.jobID, progress) } else { // An element has expired but no deletion work has been done.
Perhaps we can add logging here for now? I think the linter might complain about an empty branch anyway.
To implement cockroachdb#48775 I will be modifying the schema GC code to add support for destroying tenants data. I notice3d that the current code has redundant repetitions which makes it hard to understand and modify. The logic for computing new deadline and refreshing tables is being repeated in 3 code blocks - I have merged them together. Release note: none.
spaskob
force-pushed
the
sc-simplify-gc
branch
from
02e50bc to
d85a63d
Compare
spaskob
commented
Oct 20, 2020
There was a problem hiding this comment.
Reviewable status:
pkg/sql/gcjob/gc_job.go, line 153 at r1 (raw file):
Previously, pbardea (Paul Bardea) wrote…
Perhaps we can add logging here for now? I think the linter might complain about an empty branch anyway.
as discussed on slack we don't need to know if the performGC did any work
|
bors r+ |
|
Build succeeded: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
To implement #48775 I will be modifying the schema GC code to
add support for destroying tenants data. I noticed that the
current code has redundant repetitions which makes it hard to
understand and modify.
The logic for computing new deadline and refreshing tables is
being repeated in 3 code blocks - I have merged them together.
Release note: none.