sql: fix bug dropping shard column which is not the last column #55766
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This change is |
thoszhang
approved these changes
Oct 20, 2020
There was a problem hiding this comment.
Reviewed 2 of 2 files at r1.
Reviewable status:complete! 0 of 0 LGTMs obtained (waiting on @ajwerner)
pkg/sql/logictest/testdata/logic_test/hash_sharded_index, line 572 at r1 (raw file):
# This is a regression test for a bug whereby the dropping of a hash column # could result in an invalid descriptor and would fail. The underlying bug was # due to a column descriptor pointer to a slice being clobbered.
Would you mind referring to this PR now that it's been opened?
ajwerner
force-pushed
the
ajwerner/fix-column-drop-bug
branch
from
1896902
to
9208988
Compare
ajwerner
commented
Oct 20, 2020
There was a problem hiding this comment.
Reviewable status:
pkg/sql/logictest/testdata/logic_test/hash_sharded_index, line 572 at r1 (raw file):
Previously, lucy-zhang (Lucy Zhang) wrote…
Would you mind referring to this PR now that it's been opened?
Done.
The bug was due to the fact that we were passing around the column descriptor as a pointer to an entry in the `Columns` slice. When we overwrote that slice we'd clobber the descriptor and, in the process, muck up the mutation which pointed to it. We should look for more bugs like this. Prior to this change the added logic test would fail with the below error: ``` testdata/logic_test/hash_sharded_index:589: expected success, but found (XXUUU) family "fam_1_k_j" contains unknown column "4" ``` Release note (bug fix): Fixed a bug which would prevent the dropping of hash sharded indexes if they were added prior to other columns.
ajwerner
force-pushed
the
ajwerner/fix-column-drop-bug
branch
from
9208988
to
cb548f9
Compare
|
bors r=lucy-zhang |
|
Build succeeded: |
This was referenced Oct 21, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The bug was due to the fact that we were passing around the column descriptor
as a pointer to an entry in the
Columnsslice. When we overwrote that slicewe'd clobber the descriptor and, in the process, muck up the mutation which
pointed to it. We should look for more bugs like this. Prior to this change
the added logic test would fail with the below error:
Release note (bug fix): Fixed a bug which would prevent the dropping of hash
sharded indexes if they were added prior to other columns.