util/quotapool: add WithMinimumWait option to RateLimiter #55769
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is handy to ensure that the rate limiter does not become a bottleneck in the face of many small acquisitions. Release note: None
|
This change is |
|
@lunevalex even though the quotapool impl in our util package should be more efficient due to pooling, setting timers for nanoseconds of waiting is unlikely to be efficient no matter how you do it. This should make it trivially easy to ensure that we do some amortizing of the waiting without making the client code any uglier. |
|
LGTM, thank you. |
lunevalex
approved these changes
Oct 23, 2020
|
TFTR! bors r=lunevalex |
|
Build succeeded: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is handy to ensure that the rate limiter does not become a bottleneck
in the face of many small acquisitions.
Release note: None