logictest: add multiregion configuration #55784
Conversation
|
This change is |
|
can't seem to add @cockroachdb/multiregion as reviewers, but here's a CC. |
otan
force-pushed
the
multiregion_test
branch
from
a4cc568
to
facba9d
Compare
There was a problem hiding this comment.
Reviewable status:
complete! 0 of 0 LGTMs obtained (waiting on @ajstorm and @otan)
pkg/sql/logictest/logic.go, line 642 at r1 (raw file):
{ name: "multiregion", numNodes: 9,
Seems like it could be error prone to have the map below depend on this size. Is there some way we can generate regions (and az's) below to match whatever number is up here? I'm worried that someone will change this number, say to 15, and we'll have a bunch of nodes without localities set.
pkg/sql/logictest/logic.go, line 647 at r1 (raw file):
1: { Tiers: []roachpb.Tier{ {Key: "region", Value: "test"},
I'd think a more realistic setup would be to have 3 nodes in each region, with three different availability zones. Also, I'm thinking it might be best to have the regions be "-" delimited and the az's be either numeric or chars to match what AWS, GCP and Azure do.
There was a problem hiding this comment.
Reviewable status:
pkg/sql/logictest/logic.go, line 642 at r1 (raw file):
Previously, ajstorm wrote…
Seems like it could be error prone to have the map below depend on this size. Is there some way we can generate regions (and az's) below to match whatever number is up here? I'm worried that someone will change this number, say to 15, and we'll have a bunch of nodes without localities set.
i can deliberately rename to multiregion-9node to avoid this issue. i can also throw an assert.
pkg/sql/logictest/logic.go, line 647 at r1 (raw file):
Previously, ajstorm wrote…
I'd think a more realistic setup would be to have 3 nodes in each region, with three different availability zones. Also, I'm thinking it might be best to have the regions be "-" delimited and the az's be either numeric or chars to match what AWS, GCP and Azure do.
works for me. the spec had the space.
otan
force-pushed
the
multiregion_test
branch
3 times, most recently
from
c524079
to
0b9f8a0
Compare
There was a problem hiding this comment.
Reviewable status:
pkg/sql/logictest/logic.go, line 642 at r1 (raw file):
Previously, otan (Oliver Tan) wrote…
i can deliberately rename to
multiregion-9nodeto avoid this issue. i can also throw an assert.
Both of those sound good.
Add a logictest configuration that has three regions, with three nodes in three different AZs. Release note: None
otan
force-pushed
the
multiregion_test
branch
from
0b9f8a0
to
d531b10
Compare
There was a problem hiding this comment.
Reviewed 2 of 2 files at r2.
Reviewable status:
|
LGTM |
|
thanks! bors r=ajstorm |
|
Build succeeded: |
Add a logictest configuration that has three regions, with three
nodes in three different AZs.
Release note: None