sql: create event log entry for schema events #55785
Conversation
|
Thank you for contributing to CockroachDB. Please ensure you have followed the guidelines for creating a PR. My owl senses detect your PR is good for review. Please keep an eye out for any test failures in CI. 🦉 Hoot! I am a Blathers, a bot for CockroachDB. My owner is otan. |
|
This change is |
neeral
force-pushed
the
add_schema_events
branch
from
ce66c13
to
b3e2e98
Compare
|
Thank you for updating your pull request. My owl senses detect your PR is good for review. Please keep an eye out for any test failures in CI. 🦉 Hoot! I am a Blathers, a bot for CockroachDB. My owner is otan. |
neeral
changed the title
neeral
force-pushed
the
add_schema_events
branch
from
b3e2e98
to
32a6f42
Compare
|
PTAL @jordanlewis @knz |
|
Maybe @arulajmani you can review this too? |
|
@neeral, thanks for the contribution! |
There was a problem hiding this comment.
Reviewable status:
complete! 1 of 0 LGTMs obtained
There was a problem hiding this comment.
Forgot to hit send on this -- one small nit otherwise
Reviewable status:
pkg/sql/logictest/testdata/logic_test/event_log, line 532 at r1 (raw file):
DROP TABLE b statement okG
nit: Looks like there's an accidental G here
Previously, events were not created when schema objects were created, dropped or modified. Fixes cockroachdb#55744 Release note (admin ui change): changing schema object now causes an event to be logged and displayed in the admin ui
neeral
force-pushed
the
add_schema_events
branch
from
32a6f42
to
4641c2c
Compare
There was a problem hiding this comment.
Reviewable status:
pkg/sql/logictest/testdata/logic_test/event_log, line 532 at r1 (raw file):
Previously, arulajmani (Arul Ajmani) wrote…
nit: Looks like there's an accidental
Ghere
@arulajmani Thanks for catching this. I've removed the accidental G.
PTAL.
|
Thanks for the quick change and taking this on @neeral! bors r=jordanlewis,arulajmani |
|
Build succeeded: |
Previously, events were not created when schema objects were
created, dropped or modified.
Fixes #55744
Release note (admin ui change): changing schema object
now causes an event to be logged and displayed in the admin ui