Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix multiregion setup #55812

Merged
merged 1 commit into from
Oct 21, 2020
Merged

Fix multiregion setup #55812

merged 1 commit into from
Oct 21, 2020

Conversation

lvdlee
Copy link
Contributor

@lvdlee lvdlee commented Oct 21, 2020

The multiregion setup is missing a comma, preventing deployments ran using this file from being accessed through cockroachdb-public.default.
This adds in the extra comma and fixes the issue.

The multiregion setup is missing a comma, preventing deployments ran using this file from being accessed through `cockroachdb-public.default`.
This adds in the extra comma and fixes the issue.
@cockroach-teamcity
Copy link
Member

cockroach-teamcity commented Oct 21, 2020

CLA assistant check
All committers have signed the CLA.

@blathers-crl
Copy link

blathers-crl bot commented Oct 21, 2020

Thank you for contributing to CockroachDB. Please ensure you have followed the guidelines for creating a PR.

Before a member of our team reviews your PR, I have some potential action items for you:

  • Please ensure your git commit message contains a release note.
  • When CI has completed, please ensure no errors have appeared.

I was unable to automatically find a reviewer. You can try CCing one of the following members:

  • A person you worked with closely on this PR.
  • The person who created the ticket, or a CRDB organization member involved with the ticket (author, commenter, etc.).
  • Join our community slack channel and ask on #contributors.
  • Try find someone else from here.

🦉 Hoot! I am a Blathers, a bot for CockroachDB. My owner is otan.

@blathers-crl blathers-crl bot added O-community Originated from the community X-blathers-untriaged blathers was unable to find an owner labels Oct 21, 2020
@cockroach-teamcity
Copy link
Member

This change is Reviewable

@otan otan requested a review from DuskEagle October 21, 2020 14:24
Copy link
Member

@DuskEagle DuskEagle left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:lgtm: Thanks for the fix!

Reviewed 1 of 1 files at r1.
Reviewable status: :shipit: complete! 1 of 0 LGTMs obtained

@DuskEagle
Copy link
Member

bors r=DuskEagle

@craig
Copy link
Contributor

craig bot commented Oct 21, 2020

Build succeeded:

@craig craig bot merged commit 4b8a9c7 into cockroachdb:master Oct 21, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
O-community Originated from the community X-blathers-untriaged blathers was unable to find an owner
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants