sql: allow parsing of DROP OWNED BY #55816
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This change is |
angelapwen
force-pushed
the
parse-drop-owned-by
branch
2 times, most recently
from
410c1d5
to
90496c6
Compare
otan
reviewed
Oct 21, 2020
| @@ -8,7 +8,6 @@ exec | |||
| CREATE ROLE testuser; | |||
| CREATE ROLE testuser2; | |||
| CREATE TABLE t(); | |||
| GRANT testuser, testuser2 TO root; | |||
There was a problem hiding this comment.
I removed it because root should not need to be a member of roles in order to reassign items from one to another. It was there previously because the admin privileges were not correct but @solongordon fixed it in #55273. I removed the corresponding lines in the REASSIGN OWNED BY logic test previously but just noticed that the telemetry test still has this extraneous line.
angelapwen
force-pushed
the
parse-drop-owned-by
branch
from
90496c6
to
1e0f6fe
Compare
angelapwen
force-pushed
the
parse-drop-owned-by
branch
from
1e0f6fe
to
d263683
Compare
otan
approved these changes
Oct 21, 2020
angelapwen
force-pushed
the
parse-drop-owned-by
branch
4 times, most recently
from
a29b291
to
e3f80f1
Compare
Add parsing and telemetry support for DROP OWNED BY command. Includes small refactors of the related REASSIGN OWNED BY command such as appending "_by" to some instances of "reassign_owned" for readability. Plan to follow up with implementation of DROP OWNED BY for feature parity with PostgresQL, which will resolve the issue linked. Release note: None
angelapwen
force-pushed
the
parse-drop-owned-by
branch
from
e3f80f1
to
740f73d
Compare
|
bors r=otan |
|
This PR was included in a batch that successfully built, but then failed to merge into master (it was a non-fast-forward update). It will be automatically retried. |
|
Build succeeded: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Part 1 of addressing #55381.
Add parsing and telemetry support for DROP OWNED BY command.
Includes small refactors of the related REASSIGN OWNED BY
command such as appending "_by" to some instances of
"reassign_owned" for readability.
Plan to follow up with implementation of DROP OWNED BY for
feature parity with PostgresQL, which will resolve the issue
linked.
Note that this command is also making use of
role_spec_listwhich as noted in #54696 does not properly parse
CURRENT_USERorSESSION_USERand uses strings forroles/usernames rather than expressions. This issue is out of
scope for this PR and will be resolved separately.
Release note: None