Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Misc SQL diagram updates #55832

Merged
merged 6 commits into from
Oct 26, 2020
Merged

Misc SQL diagram updates #55832

merged 6 commits into from
Oct 26, 2020

Conversation

ericharmeling
Copy link
Contributor

@ericharmeling ericharmeling commented Oct 21, 2020

Release justification: Non-production code changes

Release note: None

See commits for list of changes.

@cockroach-teamcity
Copy link
Member

This change is Reviewable

@knz
Copy link
Contributor

knz commented Oct 22, 2020

LGTM, but teamcity is telling you something

@knz
Copy link
Contributor

knz commented Oct 23, 2020

Due to a large change in our CI scripts yesterday, we'd like you to rebase this PR one more time before you merge, otherwise you'll encounter a failure. Then after the rebase you can go ahead and bors this.

Release justification: Non-production code changes

Release note: None
Release justification: Non-production code changes

Release note: None
Release justification: Non-production code changes

Release note: None
Release justification: Non-production code changes

Release note: None
Added new for_locking diagram

Release justification: Non-production code changes

Release note: None
Added ON COMMIT PRESERVE ROWS to table diagrams

Removed "no doc" comments from sql.y on no-ops

Release justification: Non-production code changes

Release note: None
@ericharmeling
Copy link
Contributor Author

bors r+

@craig
Copy link
Contributor

craig bot commented Oct 26, 2020

Build succeeded:

@craig craig bot merged commit 6cdc3b3 into cockroachdb:master Oct 26, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants