Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

build: remove unused ROCKSDB variables #55855

Merged
merged 1 commit into from
Oct 22, 2020
Merged

build: remove unused ROCKSDB variables #55855

merged 1 commit into from
Oct 22, 2020

Conversation

jordanlewis
Copy link
Member

Release note: None

@cockroach-teamcity
Copy link
Member

This change is Reviewable

itsbilal
itsbilal approved these changes Oct 22, 2020
View reviewed changes
Copy link
Member

@itsbilal itsbilal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:lgtm: thanks for jumping on this!

Reviewed 2 of 2 files at r1.
Reviewable status: :shipit: complete! 1 of 0 LGTMs obtained

@jordanlewis
Copy link
Member Author

bors r+

@craig
Copy link
Contributor

craig bot commented Oct 22, 2020

Build succeeded:

@craig craig bot merged commit 2385a18 into cockroachdb:master Oct 22, 2020
@jordanlewis jordanlewis deleted the fix-buildbranch branch October 22, 2020 14:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@itsbilal itsbilal itsbilal approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@jordanlewis @cockroach-teamcity @itsbilal