logictest: enhance crdb_internal_tenant logic test #55860
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit copies the full crdb_internal test to crdb_internal_tenant, and rewrites it to succeed with this configuration in order to increase crdb_internal tenant test coverage. Release note: None (testing change)
|
This change is |
asubiotto
commented
Oct 22, 2020
| query B | ||
| select crdb_internal.cluster_id() != '00000000-0000-0000-0000-000000000000' FROM foo | ||
| ---- | ||
| false |
There was a problem hiding this comment.
@tbg is this expected?
There was a problem hiding this comment.
Yes, it is. The ClusterID is primarily a KV concept. Tenants could learn it only from Gossip, but they don't since that has not been necessary.
tbg
approved these changes
Oct 23, 2020
|
TFTR bors r=tbg |
|
Build succeeded: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit copies the full crdb_internal test to crdb_internal_tenant, and
rewrites it to succeed with this configuration in order to increase
crdb_internal tenant test coverage.
Release note: None (testing change)