logictest: fix comparison logic #55876
Conversation
|
This change is |
otan
force-pushed
the
logictest_breakage
branch
2 times, most recently
from
3e5eb0c
to
81498c3
Compare
There was a problem hiding this comment.
Reviewed 1 of 1 files at r2.
Reviewable status:complete! 1 of 0 LGTMs obtained (waiting on @otan)
pkg/sql/logictest/logic.go, line 2741 at r1 (raw file):
if colT == 'F' { var err error resultMatches, err = floatsMatch(expected, actual)
Your first version was correct - we now don't check whether Ok, nvm.resultMatches is true in this case.
There was a problem hiding this comment.
Reviewable status:
pkg/sql/logictest/logic.go, line 2741 at r1 (raw file):
Previously, yuzefovich wrote…
Your first version was correct - we now don't check whetherOk, nvm.resultMatchesistruein this case.
Oh wait, we still don't check resultMatches here.
|
pkg/sql/logictest/logic.go, line 2741 at r1 (raw file): Previously, yuzefovich wrote…
ah i tried to be too smart |
`9d2c054fd3e9e8c6a7d73f4e464ebd32ee82b8a2` introduced a bug in the commit logic where it would only check logic test errors for the first line, since it only compares the first column of results. This is now fixed to compare every row. Release note: None
otan
force-pushed
the
logictest_breakage
branch
from
81498c3
to
bc1b3e5
Compare
There was a problem hiding this comment.
Reviewed 1 of 1 files at r3.
Reviewable status:
|
hurray nothing broke! bors r=yuzefovich |
|
Build succeeded: |
9d2c054fd3e9e8c6a7d73f4e464ebd32ee82b8a2introduced a bug in thecommit logic where it would only check logic test errors for the first
line, since it only compares the first column of results. This is now
fixed to compare every row.
Release note: None