sql: remove vectorize=201auto option #55907
Conversation
|
This change is |
yuzefovich
force-pushed
the
remove-201auto
branch
2 times, most recently
from
e0fbd46
to
7d5edc5
Compare
There was a problem hiding this comment.
What about when the gateway is using the new version, and the other node is running the old version? Will that node run a streaming-only vectorized flow?
Reviewed 16 of 16 files at r1.
Reviewable status:complete! 0 of 0 LGTMs obtained
|
Note that the decision whether to vectorize the whole flow or not is made on the gateway, and then each node participating in the plan checks simply whether In your example, say the newer node will set |
yuzefovich
force-pushed
the
remove-201auto
branch
2 times, most recently
from
15bf9a5
to
60156fb
Compare
There was a problem hiding this comment.
In your example, say the newer node will set Vectorize=on, and the remote nodes running older version will also see on option, so they won't pay attention to the fact whether the operators are streaming or not.
Ahh gotcha, I was missing that you reserved the Vectorize201Auto field in the evalctx proto
Reviewed 2 of 2 files at r2.
Reviewable status:
pkg/sql/colflow/BUILD.bazel, line 26 at r2 (raw file):
"//pkg/sql/pgwire/pgerror", "//pkg/sql/rowexec", "//pkg/sql/sessiondatapb",
Is this removal correct?
There was a problem hiding this comment.
Hit the block by mistake
Reviewable status:
`201auto` option of `vectorize` setting has been removed since it no longer makes sense to keep (it was introduced as an escape hatch for 20.2 release). Note that we don't need to bump the distsql version because of this change since it is backwards compatible - if the gateway is running the old version that has `vectorize=201auto` set, then we will check whether flows for all nodes don't have non-streaming operators and possibly use `off` option on the flow setup request, then the newer version remote node will check the vectorize setting on the request whether it is not `off` and setup the vectorized flow if it is not. Release note (sql change): `201auto` value for `vectorize` session variable and the corresponding cluster setting has been removed.
yuzefovich
force-pushed
the
remove-201auto
branch
from
60156fb
to
67b0c4e
Compare
There was a problem hiding this comment.
TFTR!
bors r+
Reviewable status:
pkg/sql/colflow/BUILD.bazel, line 26 at r2 (raw file):
Previously, asubiotto (Alfonso Subiotto Marqués) wrote…
Is this removal correct?
Yeah - we no longer use sessiondatapb package in vectorized_flow file, so this package no longer needs to be imported when building colflow package.
|
Build succeeded: |
201autooption ofvectorizesetting has been removed since it nolonger makes sense to keep (it was introduced as an escape hatch for
20.2 release). Note that we don't need to bump the distsql version
because of this change since it is backwards compatible - if the gateway
is running the old version that has
vectorize=201autoset, then wewill check whether flows for all nodes don't have non-streaming
operators and possibly use
offoption on the flow setup request, thenthe newer version remote node will check the vectorize setting on the
request whether it is not
offand setup the vectorized flow if it isnot.
Release note (sql change):
201autovalue forvectorizesessionvariable and the corresponding cluster setting has been removed.