backupccl: do not re-create schema change jobs in cluster restore #55973
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pbardea
requested review from
a team and
miretskiy
and removed request for
a team
|
This change is |
miretskiy
approved these changes
Oct 26, 2020
There was a problem hiding this comment.
Reviewable status:
complete! 0 of 0 LGTMs obtained (waiting on @miretskiy and @pbardea)
pkg/ccl/backupccl/restore_job.go, line 1374 at r1 (raw file):
if details.DescriptorCoverage != tree.AllDescriptors { // Convert any mutations that were in progress on the table descriptor // when the backup was taken, and convert them to schema change jobs.
Perhaps expand the comment a bit to indicate why we're not doing this for allDescriptors?
pbardea
force-pushed
the
schema-change-cluster
branch
from
794c2bf
to
60ec315
Compare
pbardea
commented
Oct 26, 2020
There was a problem hiding this comment.
Reviewable status:
pkg/ccl/backupccl/restore_job.go, line 1374 at r1 (raw file):
Previously, miretskiy (Yevgeniy Miretskiy) wrote…
Perhaps expand the comment a bit to indicate why we're not doing this for allDescriptors?
Agreed. Done.
This commit fixes a bug where schema change jobs that were in progress during a cluster backup would be re-created twice during a cluster restore. Release note (bug fix): Previously if a cluster backup that was taken during a schema change, a cluster restore of that backup would create duplicates of the ongoing schema changes.
pbardea
force-pushed
the
schema-change-cluster
branch
from
60ec315
to
1c0847e
Compare
This commit expands the mid schema change restore tests to test both table and cluster restore of backups that had ongoing schema changes. This commit also adds test cases for when a schema change has not performed the backfill. This is in addition to the existing cases where the backfill has already been performed. Release note: None
pbardea
force-pushed
the
schema-change-cluster
branch
from
1c0847e
to
900cebb
Compare
|
TFTR! |
|
This PR was included in a batch that was canceled, it will be automatically retried |
|
Build succeeded: |
This was referenced Nov 6, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit fixes a bug where schema change jobs that were in progress
during a cluster backup would be re-created twice during a cluster
restore.
Release note (bug fix): Previously if a cluster backup that was taken
during a schema change, a cluster restore of that backup would create
duplicates of the ongoing schema changes.