settings: patch backwards incompatible short type identifier change #56546
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This change is |
We introduced a regression in cockroachdb#55994. In mixed-version clusters, when the 21.1 node attempts to refresh settings, it expects to find a type "v" for the version setting, but finds "m" already present in 20.2. We revert the bits of cockroachdb#55994 that introduced this regression. Release note (sql, cli change): In an earlier commit (3edd70b, not part of any release, yet) we introduced a regression by representing the shortened form of the cluster version setting's type as "v", from an earlier "m". It's now back to what it was. Specifically: - The `setting_type` column for `version` in `SHOW CLUSTER SETTINGS` will now show an "m" instead of a "v" - The `valueType` column for `version` in `system.settings` will now show an "m" instead of a "v"
irfansharif
force-pushed
the
201111.version-short-revert
branch
from
1728b2b
to
a783e9e
Compare
|
bors r+ |
|
Build succeeded: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We introduced a regression in #55994. In mixed-version clusters, when
the 21.1 node attempts to refresh settings, it expects to find a type
"v" for the version setting, but finds "m" already present in 20.2. We
revert the bits of #55994 that introduced this regression.
Release note (sql, cli change): In an earlier commit (3edd70b, not part
of any release, yet) we introduced a regression by representing the
shortened form of the cluster version setting's type as "v", from an
earlier "m". It's now back to what it was. Specifically:
- The
setting_typecolumn forversioninSHOW CLUSTER SETTINGSwill now show an "m" instead of a "v"
- The
valueTypecolumn forversioninsystem.settingswill nowshow an "m" instead of a "v"
First commit is from #56480.