-
Notifications
You must be signed in to change notification settings - Fork 3.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
sql: Add information_schema.session_variables table #57837
sql: Add information_schema.session_variables table #57837
Conversation
Thank you for contributing to CockroachDB. Please ensure you have followed the guidelines for creating a PR. My owl senses detect your PR is good for review. Please keep an eye out for any test failures in CI. I have added a few people who may be able to assist in reviewing:
🦉 Hoot! I am a Blathers, a bot for CockroachDB. My owner is otan. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewable status: complete! 0 of 0 LGTMs obtained (waiting on @jordanlewis, @nvanbenschoten, @otan, and @rafiss)
a discussion (no related file):
To the reviewer: it appears CRDB does already contain this information in crdb_internal.session_variables.
This commit is just a copy-paste from the crdb_internal.session_variables without hidden
column.
Please let me know if hidden variables should be filtered out: allow_prepare_as_opt_plan, save_tables_prefix, session_authorization, ssl_renegotiation_limit
c66de92
to
71641a6
Compare
Thank you for updating your pull request. My owl senses detect your PR is good for review. Please keep an eye out for any test failures in CI. 🦉 Hoot! I am a Blathers, a bot for CockroachDB. My owner is otan. |
377855d
to
bb2fa33
Compare
The `session_variables` table exposes the session variables. Related to: cockroachdb#8675 Release note (sql change): Added session_variables table to the information_schema.
bb2fa33
to
6bdf208
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
thanks for your contribution!
bors r+
Build succeeded: |
sql: Add information_schema.session_variables table
The
session_variables
table exposes the session variables.Related to: #8675
Release note (sql change): Added session_variables table to the information_schema.