Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

sql: Add information_schema.session_variables table #57837

Merged
merged 1 commit into from
Dec 23, 2020

Conversation

mneverov
Copy link
Contributor

sql: Add information_schema.session_variables table

The session_variables table exposes the session variables.
Related to: #8675

Release note (sql change): Added session_variables table to the information_schema.

@blathers-crl
Copy link

blathers-crl bot commented Dec 11, 2020

Thank you for contributing to CockroachDB. Please ensure you have followed the guidelines for creating a PR.

My owl senses detect your PR is good for review. Please keep an eye out for any test failures in CI.

I have added a few people who may be able to assist in reviewing:

🦉 Hoot! I am a Blathers, a bot for CockroachDB. My owner is otan.

@blathers-crl blathers-crl bot added O-community Originated from the community X-blathers-triaged blathers was able to find an owner labels Dec 11, 2020
@cockroach-teamcity
Copy link
Member

This change is Reviewable

Copy link
Contributor Author

@mneverov mneverov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewable status: :shipit: complete! 0 of 0 LGTMs obtained (waiting on @jordanlewis, @nvanbenschoten, @otan, and @rafiss)

a discussion (no related file):
To the reviewer: it appears CRDB does already contain this information in crdb_internal.session_variables.
This commit is just a copy-paste from the crdb_internal.session_variables without hidden column.
Please let me know if hidden variables should be filtered out: allow_prepare_as_opt_plan, save_tables_prefix, session_authorization, ssl_renegotiation_limit


@mneverov mneverov force-pushed the info_schema_session_variables branch from c66de92 to 71641a6 Compare December 11, 2020 21:30
@blathers-crl
Copy link

blathers-crl bot commented Dec 11, 2020

Thank you for updating your pull request.

My owl senses detect your PR is good for review. Please keep an eye out for any test failures in CI.

🦉 Hoot! I am a Blathers, a bot for CockroachDB. My owner is otan.

@mneverov mneverov force-pushed the info_schema_session_variables branch 5 times, most recently from 377855d to bb2fa33 Compare December 15, 2020 17:07
The `session_variables` table exposes the session variables.
Related to: cockroachdb#8675

Release note (sql change): Added session_variables table to the information_schema.
@mneverov mneverov force-pushed the info_schema_session_variables branch from bb2fa33 to 6bdf208 Compare December 16, 2020 06:26
Copy link
Collaborator

@rafiss rafiss left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks for your contribution!

bors r+

@craig
Copy link
Contributor

craig bot commented Dec 23, 2020

Build succeeded:

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
O-community Originated from the community X-blathers-triaged blathers was able to find an owner
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants