Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

server: add poller for tenant cluster settings #57926

Closed
wants to merge 3 commits into from
Closed

server: add poller for tenant cluster settings #57926

wants to merge 3 commits into from

Commits on Dec 16, 2020

  1. server: add poller for tenant cluster settings 

    System tenants can maintain their in-memory cluster settings caches by
listening for the gossip updates on their system.settings table and then
updating the in-memory cache directly off the decoded gossip events.

Tenants however do not have changes to their system tables gossiped
and thus have to use either polling or rangefeeds if they want to
notice changes therein.

This change adds a simple poller to re-read the system.settings
table to update the in-memory settings which is started for tenant
SQL servers that do not start the old gossip updater.

This change also removes the limits in the SET CLUSTER SETTING
code path that prevented tenants writing to their settings table
before those changes would have had any effect.

Release note: none.
    @dt
    dt committed Dec 16, 2020
    Configuration menu
    Copy the full SHA
    0a83371 View commit details
    Browse the repository at this point in the history

  2. settings: add SystemOnly flag 

    This change adds a flag to indicate a setting is only applicable to the
system tenant, such as those that control storage layer behaviors, and
thus should not be set by guest tenants (where it would be ignored).

Release note: none.
    @dt
    dt committed Dec 16, 2020
    Configuration menu
    Copy the full SHA
    11e976a View commit details
    Browse the repository at this point in the history

  3. cli/gen,Makefile: generate list of tenant-ok settings 

    This adds a generated listing of the settings available to tenants, i.e.
settings which are not system-only. This generated listing is checked in
so that reviewers will notice if a new setting is there that should not
be presented to tenants.

Release note: none.
    @dt
    dt committed Dec 16, 2020
    Configuration menu
    Copy the full SHA
    962cb25 View commit details
    Browse the repository at this point in the history