opt: always add deletable index predicates to table metadata #58714
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This change is |
There is no need to avoid adding deletable indexes to the table metadata in the context of a Select. Exploration rules that require access to partial index predicates must already discriminate between public and write/delete-only indexes. For example, `scanIndexIter` only considers public indexes. Therefore, the partial index predicates in the table metadata do not need to be an indication of what indexes are available for a Select query to use. This reduces the complexity of some optbuilder code. Release note: None
mgartner
force-pushed
the
always-add-deletable-indexes-to-metadata
branch
from
fec2ea2
to
a308dd5
Compare
RaduBerinde
approved these changes
Jan 11, 2021
There was a problem hiding this comment.
Reviewable status:
complete! 1 of 0 LGTMs obtained (waiting on @RaduBerinde)
|
bors r=RaduBerinde |
|
Build succeeded: |
mgartner
added a commit
to mgartner/cockroach
that referenced
this pull request
Aug 14, 2021
This commit removes a stale comment that should have been removed in a previous commit (see cockroachdb#58714). Release note: None
craig bot
pushed a commit
that referenced
this pull request
Aug 14, 2021
68904: dev: strip out trailing slashes in targets/packages r=rail a=rickystewart Bash auto-complete often puts these trailing slashes in, but we can strip them out before we pass them on to `bazel` (which will throw an error if package names end with a slash). Release note: None 68905: colexec: fix recent change to the parallel unordered synchronizer r=yuzefovich a=yuzefovich We recently made the parallel unordered synchronizer cancel its local inputs eagerly whenever the sync transitions into the draining state. However, we currently incorrectly calculate whether the input is "local": essentially we look only at the children of each input tree root but not deeper. In order to fix it we could have implemented a proper input tree traversal, but it has its complications because we sometimes wrap operators with another, and in order to perform the type check, we would need to unwrap the operator first. That could be error-prone. Instead, this commit chooses a more safe option of using the eager cancellation only if the plan is fully local - in this case we know for sure that aren't any inboxes. This is still sufficient for the use case of parallel TableReaders in the local flows that this eager cancellation was introduced for. Fixes: #68884. Release note: None (no stable release with this bug) 68919: logictest: move window functions from aggregate file r=yuzefovich a=yuzefovich Release note: None 68927: opt: remove stale comment r=mgartner a=mgartner This commit removes a stale comment that should have been removed in a previous commit (see #58714). Release note: None Co-authored-by: Ricky Stewart <ricky@cockroachlabs.com> Co-authored-by: Yahor Yuzefovich <yahor@cockroachlabs.com> Co-authored-by: Marcus Gartner <marcus@cockroachlabs.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There is no need to avoid adding deletable indexes to the table metadata
in the context of a Select. Exploration rules that require access to
partial index predicates must already discriminate between public and
write/delete-only indexes. For example,
scanIndexIteronly considerspublic indexes. Therefore, the partial index predicates in the table
metadata do not need to be an indication of what indexes are available
for a Select query to use. This reduces the complexity of some
optbuilder code.
Release note: None