kvnemesis: add lease transfers #59008
Conversation
|
This change is |
nvanbenschoten
force-pushed
the
nvanbenschoten/kvnemesisLeaseTransfer
branch
from
1b75ced to
ef4c1bb
Compare
This commit adds lease transfers to KV nemesis. This will be useful in validating that I don't mess anything up when addressing cockroachdb#57688 or when performing the precursor refactor to pull lease checks below latching. I stressed this for 50,000 iterations on a 20 node roachprod cluster without failure, so it looks like lease transfers aren't already broken!
nvanbenschoten
force-pushed
the
nvanbenschoten/kvnemesisLeaseTransfer
branch
from
ef4c1bb to
c575d5c
Compare
There was a problem hiding this comment.
Very nice!
Reviewable status:
complete! 1 of 0 LGTMs obtained (waiting on @nvanbenschoten)
pkg/kv/kvnemesis/generator.go, line 123 at r1 (raw file):
// ChangeReplicasConfig configures the relative probability of generating a // ChangeReplicas operation. type ChangeReplicasConfig struct {
Would you mind adding a TODO here about supporting non-voter addition/removal (and assigning to me)?
There was a problem hiding this comment.
TFTR!
bors r+
Reviewable status:
pkg/kv/kvnemesis/generator.go, line 123 at r1 (raw file):
Previously, aayushshah15 (Aayush Shah) wrote…
Would you mind adding a TODO here about supporting non-voter addition/removal (and assigning to me)?
I opened #59060 and #59061 so we can track these in Github. These will both be great ways to extend our randomized testing coverage over new functionality. I'll also be doing #59062 in this release cycle.
|
This PR was included in a batch that was canceled, it will be automatically retried |
|
Build failed (retrying...): |
|
Build succeeded: |
This commit adds lease transfers to KV nemesis. This will be useful in validating that I don't mess anything up when addressing #57688 or when performing the precursor refactor to pull lease checks below latching.
I stressed this for 50,000 iterations on a 20 node roachprod cluster without failure, so it looks like lease transfers aren't already broken!