roachtest/tpcc: reduce load during rebalance period #59206
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Relates to cockroachdb#58298. One thing I've noticed when looking into cockroachdb#58298 is that we were often badly overloading the cluster during the rebalance wait period. During this time, we just want to apply a small amount of load to help instruct load-based splitting and rebalancing. But in some cases, we were completely overloading the cluster. We also weren't ramping up the load, as we had intended to. This commit fixes both of these issues. It adds a ramp period for the first quarter of the rebalance time and it scales the txn rate based on the expected max warehouse count instead of the loaded warehouse count.
|
This change is |
complete! 1 of 0 LGTMs obtained
|
bors r+ |
|
Build succeeded: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Relates to #58298.
One thing I've noticed when looking into #58298 is that we were often
badly overloading the cluster during the rebalance wait period. During
this time, we just want to apply a small amount of load to help instruct
load-based splitting and rebalancing. But in some cases, we were
completely overloading the cluster. We also weren't ramping up the load,
as we had intended to.
This commit fixes both of these issues. It adds a ramp period for the
first quarter of the rebalance time and it scales the txn rate based on
the expected max warehouse count instead of the loaded warehouse count.