Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ui: Sessions page reintegration #59539

Merged
merged 1 commit into from
Feb 24, 2021

Conversation

vladlos
Copy link
Contributor

@vladlos vladlos commented Jan 28, 2021

update cluster-ui to latest version, minor updates to sessions,
sessions details and statements details pages to provide new
props needed by cluster-ui components.

Release note (ui): none

@cockroach-teamcity
Copy link
Member

This change is Reviewable

@vladlos vladlos force-pushed the sessions-reintegration branch 2 times, most recently from 27901d4 to bce9407 Compare February 18, 2021 13:54
@vladlos
Copy link
Contributor Author

vladlos commented Feb 18, 2021

corresponding yarn vendors pr cockroachdb/yarn-vendored#57

@vladlos vladlos marked this pull request as ready for review February 18, 2021 13:56
@vladlos vladlos requested a review from a team February 18, 2021 13:56
@vladlos vladlos force-pushed the sessions-reintegration branch from bce9407 to c95c747 Compare February 19, 2021 13:30
Copy link
Collaborator

@dhartunian dhartunian left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:lgtm: I retriggered teamcity build. let me know if it continues to fail.

Reviewable status: :shipit: complete! 1 of 0 LGTMs obtained

@vladlos
Copy link
Contributor Author

vladlos commented Feb 23, 2021

bors r+

@craig
Copy link
Contributor

craig bot commented Feb 23, 2021

Build failed:

@vladlos vladlos force-pushed the sessions-reintegration branch 2 times, most recently from 6d68d05 to c68e985 Compare February 23, 2021 13:28
update cluster-ui to latest version, minor updates to sessions,
sessions details and statements details pages to provide new
props needed by cluster-ui components.

Release note (ui): none
@vladlos vladlos force-pushed the sessions-reintegration branch from c68e985 to fa84941 Compare February 23, 2021 14:20
@vladlos
Copy link
Contributor Author

vladlos commented Feb 23, 2021

bors r+

@craig
Copy link
Contributor

craig bot commented Feb 23, 2021

Build failed (retrying...):

@craig
Copy link
Contributor

craig bot commented Feb 23, 2021

This PR was included in a batch that was canceled, it will be automatically retried

@craig
Copy link
Contributor

craig bot commented Feb 24, 2021

Build succeeded:

@craig craig bot merged commit 1f6c36c into cockroachdb:master Feb 24, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants