Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

workload/schemachange: "fix" workload #59635

Merged
merged 20 commits into from
Mar 16, 2021
Merged

workload/schemachange: "fix" workload #59635

merged 20 commits into from
Mar 16, 2021

Commits on Mar 16, 2021

  1. sql: wrap error correctly in drop view 

    Before this we would end up swallowing errors needed by the higher layers
like transaction restarts.

Release note: None
    @ajwerner
    ajwerner committed Mar 16, 2021
    Configuration menu
    Copy the full SHA
    6600f45 View commit details
    Browse the repository at this point in the history

  2. workload/schemachange: add a test to run the workload against a testc… 

    …luster

Release note: None
    @ajwerner
    ajwerner committed Mar 16, 2021
    Configuration menu
    Copy the full SHA
    9cd7be7 View commit details
    Browse the repository at this point in the history

  3. workload/schemachange: extend test to have concurrency 

    Release note: None
    @ajwerner
    ajwerner committed Mar 16, 2021
    Configuration menu
    Copy the full SHA
    ebc40a7 View commit details
    Browse the repository at this point in the history

  4. workload/schemachange: properly detect that self-references are ok 

    We used to expect `DROP TABLE ... RESTRICT` to fail when the table was
involved in an FK relation. It's fine.

Release note: None
    @ajwerner
    ajwerner committed Mar 16, 2021
    Configuration menu
    Copy the full SHA
    01be19c View commit details
    Browse the repository at this point in the history

  5. workload/schemachange: detect when a column is part of an index mutation 

    We don't allow dropping it in this case.

Release note: None
    @ajwerner
    ajwerner committed Mar 16, 2021
    Configuration menu
    Copy the full SHA
    85668ca View commit details
    Browse the repository at this point in the history

  6. workload/schemachange: detect not null constraints being concurrently… 

    … added

Release note: None
    @ajwerner
    ajwerner committed Mar 16, 2021
    Configuration menu
    Copy the full SHA
    503059e View commit details
    Browse the repository at this point in the history

  7. workload/schemachange: don't expect errors if the sequence already ex… 

    …ists

Release note: None
    @ajwerner
    ajwerner committed Mar 16, 2021
    Configuration menu
    Copy the full SHA
    e8547db View commit details
    Browse the repository at this point in the history

  8. workload/schemachange: properly detect writes preceding DDLs 

    Before this commit we'd only look at the previous operation, not all
previous operations. This became a problem when validation was added.

Release note: None
    @ajwerner
    ajwerner committed Mar 16, 2021
    Configuration menu
    Copy the full SHA
    6304018 View commit details
    Browse the repository at this point in the history

  9. workload/schemachange: stop swallowing all errors during op generation 

    Transaction restart errors must be rolled all the way back. Not doing that
means the workload totally fails. Also, we want to treat uncategorized errors
in generation as a real problem.

Release note: None
    @ajwerner
    ajwerner committed Mar 16, 2021
    Configuration menu
    Copy the full SHA
    7d5c67c View commit details
    Browse the repository at this point in the history

  10. workload/schemachange: deal with columns not existing in check 

    Could cause an error which was previously being swallowed.

Release note: None
    @ajwerner
    ajwerner committed Mar 16, 2021
    Configuration menu
    Copy the full SHA
    33bd870 View commit details
    Browse the repository at this point in the history

  11. workload/schemachange: only check if a table has rows if it exists 

    Release note: None
    @ajwerner
    ajwerner committed Mar 16, 2021
    Configuration menu
    Copy the full SHA
    8367eb7 View commit details
    Browse the repository at this point in the history

  12. workload/schemachange: fix broken query that was not scanning a schem… 

    …a name

Release note: None
    @ajwerner
    ajwerner committed Mar 16, 2021
    Configuration menu
    Copy the full SHA
    8946d0c View commit details
    Browse the repository at this point in the history

  13. workload/schemachange: detect schemas with cross-schema type references 

    Release note: None
    @ajwerner
    ajwerner committed Mar 16, 2021
    Configuration menu
    Copy the full SHA
    fe16420 View commit details
    Browse the repository at this point in the history

  14. workload/schemachange: wrap errors for easier debugging 

    Release note: None
    @ajwerner
    ajwerner committed Mar 16, 2021
    Configuration menu
    Copy the full SHA
    62d64d3 View commit details
    Browse the repository at this point in the history

  15. workload/schemachange: add support for multi-column inverted indexes 

    Fixed by cockroachdb#59565.

Release justification: Testing only.

Release note: None
    @ajwerner
    ajwerner committed Mar 16, 2021
    Configuration menu
    Copy the full SHA
    a699c4f View commit details
    Browse the repository at this point in the history

  16. workload/schemachange: fix locking bug when an error is encountered 

    Release note: None
    @ajwerner
    ajwerner committed Mar 16, 2021
    Configuration menu
    Copy the full SHA
    6fe27e4 View commit details
    Browse the repository at this point in the history

  17. workload/schemachange: detect when a constraint is being dropped 

    We currently return an error indicating that this is unsupported.

Release justification: non-production code changes

Release note: None
    @ajwerner
    ajwerner committed Mar 16, 2021
    Configuration menu
    Copy the full SHA
    2eb6c86 View commit details
    Browse the repository at this point in the history

  18. workload/schemachange: detect virtual computed columns 

    Release note: None
    @ajwerner
    ajwerner committed Mar 16, 2021
    Configuration menu
    Copy the full SHA
    cea972d View commit details
    Browse the repository at this point in the history

  19. workload/schemachange: partial work to support insert row 

    Release note: None
    @ajwerner
    ajwerner committed Mar 16, 2021
    Configuration menu
    Copy the full SHA
    661955a View commit details
    Browse the repository at this point in the history

  20. workload/schemachange: disable operations which do not currently work 

    These all should be re-enabled but they current have problems.

Release note: None
    @ajwerner
    ajwerner committed Mar 16, 2021
    Configuration menu
    Copy the full SHA
    4f62dba View commit details
    Browse the repository at this point in the history