build: fix documentation on updating the builder image given #56987 #59861
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This change is |
rickystewart
force-pushed
the
docker_docs
branch
from
0f732c9
to
4c1976b
Compare
rickystewart
changed the title
jlinder
reviewed
Feb 9, 2021
rickystewart
force-pushed
the
docker_docs
branch
from
4c1976b
to
5515393
Compare
jlinder
reviewed
Feb 11, 2021
build/README.md
Outdated
|
|
||
| ### Using TeamCity to build and deploy | ||
|
|
||
| - Edit `build/builder/Dockerfile` as desired and commit your changes. |
There was a problem hiding this comment.
Heh. I didn't do a good enough job describing what I was thinking. How about a change like this to the first text you had put in (with only one way of pushing the image to docker hub via the TC build configuration).
Suggested change
| - Edit `build/builder/Dockerfile` as desired and commit your changes. | |
| - Edit `build/builder/Dockerfile` as desired | |
| - Run `build/builder.sh init` to test -- this will build the image locally. Beware this can take a lot of time. The result of `init` is a docker image version which you can subsequently stick into the `version` variable inside the `builder.sh` script for testing locally. | |
| - Commit your changes once you are happy with the result. |
There was a problem hiding this comment.
I think that this is more or less what you meant? Let me know.
…hdb#56987 Release note: None
rickystewart
force-pushed
the
docker_docs
branch
from
5515393
to
aa05da8
Compare
jlinder
approved these changes
Feb 16, 2021
|
bors r+ |
|
Build succeeded: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Release note: None