Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

kvserver: improve a test under race #60506

Merged
merged 1 commit into from
Feb 13, 2021
Merged

kvserver: improve a test under race #60506

merged 1 commit into from
Feb 13, 2021

Conversation

andreimatei
Copy link
Contributor

This test had a tiny closed ts target duration, which under race caused
a merge to retry for 10s until finally succeeding.

Release note: None

@andreimatei
kvserver: improve a test under race
d4c0e60 
This test had a tiny closed ts target duration, which under race caused
a merge to retry for 10s until finally succeeding.

Release note: None
@cockroach-teamcity
Copy link
Member

This change is Reviewable

@andreimatei
Copy link
Contributor Author

bors r+

@craig
Copy link
Contributor

craig bot commented Feb 12, 2021

Build failed (retrying...):

@nvanbenschoten nvanbenschoten mentioned this pull request Feb 12, 2021
Merged
@craig
Copy link
Contributor

craig bot commented Feb 13, 2021

Build succeeded:

@craig craig bot merged commit 36e5c38 into cockroachdb:master Feb 13, 2021
@andreimatei andreimatei deleted the small.race-test-closedts branch January 21, 2022 17:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nvanbenschoten nvanbenschoten nvanbenschoten approved these changes

@ajwerner ajwerner Awaiting requested review from ajwerner

@aayushshah15 aayushshah15 Awaiting requested review from aayushshah15

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@andreimatei @cockroach-teamcity @nvanbenschoten