builtins: change complete_stream builtin to take a timestamp #60543
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This change is |
miretskiy
approved these changes
Feb 12, 2021
adityamaru
force-pushed
the
add-ts-to-builtin
branch
from
744901a
to
ae32109
Compare
pbardea
approved these changes
Feb 12, 2021
docs/generated/sql/functions.md
Outdated
| @@ -2274,7 +2274,7 @@ The swap_ordinate_string parameter is a 2-character string naming the ordinates | |||
| <table> | |||
| <thead><tr><th>Function → Returns</th><th>Description</th></tr></thead> | |||
| <tbody> | |||
| <tr><td><a name="crdb_internal.complete_stream_ingestion_job"></a><code>crdb_internal.complete_stream_ingestion_job(job_id: <a href="int.html">int</a>) → <a href="int.html">int</a></code></td><td><span class="funcdesc"><p>This function can be used to signal a running stream ingestion job to complete. The job will eventually stop ingesting, revert to the latest resolved timestamp and leave the cluster in a consistent state. This function does not wait for the job to reach a terminal state, but instead returns the job id as soon as it has signaled the job to complete. This builtin can be used in conjunction with SHOW JOBS WHEN COMPLETE to ensure that the job has left the cluster in a consistent state.</p> | |||
| <tr><td><a name="crdb_internal.complete_stream_ingestion_job"></a><code>crdb_internal.complete_stream_ingestion_job(job_id: <a href="int.html">int</a>, cutover_ts: <a href="timestamp.html">timestamptz</a>) → <a href="int.html">int</a></code></td><td><span class="funcdesc"><p>This function can be used to signal a running stream ingestion job to complete. The job will eventually stop ingesting, revert to the latest resolved timestamp and leave the cluster in a consistent state. This function does not wait for the job to reach a terminal state, but instead returns the job id as soon as it has signaled the job to complete. This builtin can be used in conjunction with SHOW JOBS WHEN COMPLETE to ensure that the job has left the cluster in a consistent state.</p> | |||
There was a problem hiding this comment.
Let's update the description here. It will cut over to the specified timestamp rather than the "latest resolved timestamp".
It may also be worth calling out that the cutover timestamp can "only" (that should be enough?) be specified up to the millisecond.
adityamaru
force-pushed
the
add-ts-to-builtin
branch
from
ae32109
to
44eaebb
Compare
This change adds a ts parameter to crdb_internal.complete_stream_ingestion_job builtin. This ts will be the ts as of which the cluster being ingested into will be considered in a consistent state. Release note: None
adityamaru
force-pushed
the
add-ts-to-builtin
branch
from
44eaebb
to
8494822
Compare
|
TFTR! bors r=pbardea,miretskiy |
|
Build succeeded: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change adds a ts parameter to
crdb_internal.complete_stream_ingestion_job builtin. This ts will be the
ts as of which the cluster being ingested into will be considered in a
consistent state.
Release note: None