Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

go.mod: bump etcd/raft to pick up probing improvements #60581

Merged
merged 1 commit into from
Feb 16, 2021

Conversation

tbg
Copy link
Member

@tbg tbg commented Feb 15, 2021

This picks up this PR:

etcd-io/etcd#11964

There were no other code changes affecting raft.

Release note (bug fix): fixed a deficiency in the replication layer
that could result in ranges becoming unavailable for prolonged periods
of time (hours) when a write burst occurred under system overload.
While unavailable, the range status page for the affected range would
show a last index much larger than the committed index and no movement
in these indexes on a quorum of the replicas. Note that this should
be distinguished from the case in which enough replicas are offline
to constitute a loss of quorum, where the replication layer can not
make progress due to the loss of quorum itself.

@cockroach-teamcity
Copy link
Member

This change is Reviewable

@stevendanna
Copy link
Collaborator

Looks like you might need to run make bazel-generate

Copy link
Member

@nvanbenschoten nvanbenschoten left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM once CI is happy.

This picks up this PR:

etcd-io/etcd#11964

There were no other code changes affecting raft.

Release note (bug fix): fixed a deficiency in the replication layer
that could result in ranges becoming unavailable for prolonged periods
of time (hours) when a write burst occurred under system overload.
While unavailable, the range status page for the affected range would
show a last index much larger than the committed index and no movement
in these indexes on a quorum of the replicas. Note that this should
be distinguished from the case in which enough replicas are offline
to constitute a loss of quorum, where the replication layer can not
make progress due to the loss of quorum itself.
@tbg
Copy link
Member Author

tbg commented Feb 16, 2021

bors r=nvanbenschoten

@craig
Copy link
Contributor

craig bot commented Feb 16, 2021

Build failed (retrying...):

@craig
Copy link
Contributor

craig bot commented Feb 16, 2021

Build failed (retrying...):

@craig
Copy link
Contributor

craig bot commented Feb 16, 2021

Build succeeded:

@craig craig bot merged commit a296e70 into cockroachdb:master Feb 16, 2021
@tbg tbg deleted the bump-raft-probing branch March 11, 2021 15:22
tbg added a commit to tbg/cockroach that referenced this pull request Mar 25, 2021
This picks up the fix in
cockroachdb#60581.

Since this is the first time on this branch to pick up a version of raft
that post-dates its move to a Go module, there is a large diff, very
similar to cockroachdb#56233.

Release note (bug fix): fixed a deficiency in the replication layer
that could result in ranges becoming unavailable for prolonged periods
of time (hours) when a write burst occurred under system overload.
While unavailable, the range status page for the affected range would
show a last index much larger than the committed index and no movement
in these indexes on a quorum of the replicas. Note that this should
be distinguished from the case in which enough replicas are offline
to constitute a loss of quorum, where the replication layer can not
make progress due to the loss of quorum itself.

/cc @cockroachdb/release
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants