Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

parser: add alias for ALTER DATABASE ... SET PRIMARY REGION #60603

Merged
merged 2 commits into from
Feb 16, 2021

Conversation

otan
Copy link
Contributor

@otan otan commented Feb 16, 2021

Resolves #59247

Release note: None

@otan otan requested review from ajstorm and a team February 16, 2021 01:26
@cockroach-teamcity
Copy link
Member

This change is Reviewable

Fix hints where SET PRIMARY REGION is suggested into the more "normal"
form PRIMARY REGION.

Release note: None
Copy link
Collaborator

@ajstorm ajstorm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:lgtm:

Reviewed 2 of 2 files at r1, 3 of 3 files at r2.
Reviewable status: :shipit: complete! 1 of 0 LGTMs obtained

@otan
Copy link
Contributor Author

otan commented Feb 16, 2021

bors r=ajstorm

@craig
Copy link
Contributor

craig bot commented Feb 16, 2021

Build succeeded:

@craig craig bot merged commit 497a9c0 into cockroachdb:master Feb 16, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

sql: alter database set primary region does not work
3 participants