Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bazel: fix up name of forbiddenmethod library target #60627

Merged
merged 1 commit into from
Feb 18, 2021

Conversation

rickystewart
Copy link
Collaborator

This was moved wholesale from a directory called descriptormarshal,
so it retained its old library name. This isn't the normal style we're
using and I'm concerned about how Gazelle will handle this going
forward, so change it to the expected style. Also delete an accidentally
duplicated test.

Release note: None

@cockroach-teamcity
Copy link
Member

This change is Reviewable

Copy link
Contributor

@alan-mas alan-mas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm +1 gazelle is working as expected now with this library name change!

@rickystewart
Copy link
Collaborator Author

bors r+

@craig
Copy link
Contributor

craig bot commented Feb 17, 2021

This PR was included in a batch that was canceled, it will be automatically retried

@craig
Copy link
Contributor

craig bot commented Feb 17, 2021

Merge conflict.

This was moved wholesale from a directory called `descriptormarshal`,
so it retained its old library name. This isn't the normal style we're
using and I'm concerned about how Gazelle will handle this going
forward, so change it to the expected style. Also delete an accidentally
duplicated test.

Release note: None
@rickystewart
Copy link
Collaborator Author

bors r+

@craig
Copy link
Contributor

craig bot commented Feb 18, 2021

Build failed (retrying...):

@craig
Copy link
Contributor

craig bot commented Feb 18, 2021

Build succeeded:

@craig craig bot merged commit 9171f18 into cockroachdb:master Feb 18, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants