colexec: remove duplication around bazel utility functions #60993
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This change is |
irfansharif
approved these changes
Feb 23, 2021
pkg/sql/colexecbase/EXECGEN.bzl
Outdated
| @@ -71,3 +48,7 @@ def gen_eg_go_rules(): | |||
| """, | |||
| tools = [":execgen", ":goimports"], | |||
| ) | |||
|
|
|||
| def rule_name_for(target, visibility=["//visibility:private"]): | |||
There was a problem hiding this comment.
Does this visibility annotation do anything? We're not really using it, no?
yuzefovich
commented
Feb 23, 2021
There was a problem hiding this comment.
TFTR!
bors r+
Reviewable status:
complete! 0 of 0 LGTMs obtained (waiting on @irfansharif and @rickystewart)
pkg/sql/colexecbase/EXECGEN.bzl, line 52 at r1 (raw file):
Previously, irfansharif (irfan sharif) wrote…
Does this visibility annotation do anything? We're not really using it, no?
I thought it would prohibit from importing this function into another packages, but it seems like it doesn't do anything as you correctly pointed out, so I removed it.
Previously, we had essentially duplicated `.bzl` files in two packages that need to generate code using `execgen`, but this can be avoided by defining a separate `.bzl` file as an extension used in both places. Release note: None
|
Canceled. |
|
bors was saying there was a merge conflict, so I rebased and force-pushed (probably that was on a concurrent PR though). bors r+ |
|
Build succeeded: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously, we had essentially duplicated
.bzlfiles in two packagesthat need to generate code using
execgen, but this can be avoided bydefining a separate
.bzlfile as an extension used in both places.Release note: None