kvserver: re-add spuriously removed nil check in relocateOne
#61094
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This change is |
aayushshah15
force-pushed
the
20210224_tpccbench-nullptr-fix
branch
from
4eeb845
to
06401ce
Compare
nvanbenschoten
approved these changes
Feb 25, 2021
There was a problem hiding this comment.
Not that it matters, but I think this was actually removed in bce8317.
Reviewed 1 of 1 files at r1.
Reviewable status:complete! 1 of 0 LGTMs obtained
e924d91 introduced a bug by spuriously removing a nil check over the result of a call to `allocateTargetFromList`. This commit re-adds the check. The bug could cause a panic when `AdminRelocateRange` was called by the `StoreRebalancer` or the `mergeQueue` if one (or more) of the stores that are supposed to receive a replica for a range become unfit for receiving the replica (due to balancing reasons / or shifting constraints) _between when rebalancing decision is made and when it's executed_. Resolves cockroachdb#60812 Release justification: fixes bug that causes a panic Release note: None
aayushshah15
force-pushed
the
20210224_tpccbench-nullptr-fix
branch
from
06401ce
to
72be631
Compare
|
TFTR! bors r+ |
|
Build succeeded: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
bce8317 introduced a bug by spuriously
removing a nil check over the result of a call to
allocateTargetFromList. This commit re-adds the check.The bug could cause a panic when
AdminRelocateRangewas called by theStoreRebalanceror themergeQueueif one (or more) of the storesthat are supposed to receive a replica for a range become unfit for
receiving the replica (due to balancing reasons / or shifting
constraints) between when rebalancing decision is made and when it's
executed.
Resolves #60812
Release justification: fixes bug that causes a panic
Release note: None