sql: disallow adding OIDVECTOR and INT2VECTOR columns #61763
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This change is |
mgartner
force-pushed
the
disallow-oidvector-alter
branch
2 times, most recently
from
2a97bbe
to
cda2247
Compare
rytaft
approved these changes
Mar 16, 2021
There was a problem hiding this comment.
Reviewed 2 of 2 files at r1.
Reviewable status:complete! 1 of 0 LGTMs obtained (waiting on @RaduBerinde)
Creating columns of type `OIDVECTOR` or `INT2VECTOR` is not allowed in `CREATE TABLE` statements. This commit disallows these types in `ALTER TABLE ... ADD COLUMN` statements for consistency. Fixes cockroachdb#61762 Release justification: This is a low-risk bug fix. Release note (bug fix): Adding columns of type `OIDVECTOR` or `INT2VECTOR` to a table in `ALTER TABLE ... ADD COLUMN` statements is no longer allowed. These types are not allowed in user-created tables via `CREATE TABLE ` and were erroneously allowed previously in `ALTER TABLE ... ADD COLUMN`.
mgartner
force-pushed
the
disallow-oidvector-alter
branch
from
cda2247
to
d715f4a
Compare
|
TFTR bors r+ |
|
Build succeeded: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Creating columns of type
OIDVECTORorINT2VECTORis not allowed inCREATE TABLEstatements. This commit disallows these types inALTER TABLE ... ADD COLUMNstatements for consistency.Fixes #61762
Release justification: This is a low-risk bug fix.
Release note (bug fix): Adding columns of type
OIDVECTORorINT2VECTORto a table inALTER TABLE ... ADD COLUMNstatements is nolonger allowed. These types are not allowed in user-created tables via
CREATE TABLEand were erroneously allowed previously inALTER TABLE ... ADD COLUMN.