sql/sem/tree: properly serialize physical values of enums #61933
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This change is |
ajwerner
force-pushed
the
ajwerner/fix-large-enums
branch
from
2a1861a to
8187ca0
Compare
arulajmani
approved these changes
Mar 15, 2021
There was a problem hiding this comment.
Reviewable status:
complete! 1 of 0 LGTMs obtained (waiting on @ajwerner)
pkg/sql/sem/tree/datum.go, line 1447 at r1 (raw file):
writeAsHexString(ctx, d) ctx.WriteString(`"`) } else if f.HasFlags(fmtFormatByteLiterals) {
nit: could you update the comment on fmtFormatByteLiterals to reflect this change
pkg/sql/tests/enum_test.go, line 19 at r1 (raw file):
) func TestLargeEnums(t *testing.T) {
Nice test! 💯
ajwerner
changed the title
ajwerner
force-pushed
the
ajwerner/fix-large-enums
branch
3 times, most recently
from
8b2b038 to
dad7087
Compare
The optimizer generates check constraints for enums. It does so by writing these constraints as physical values. Unfortunately the way we serialized these physical values was bogus if the enum's physical value was more than one byte long. The reason was because of a difference between string literal and byte string literals and their use of `\x`. This fixes that by using hex byte string literals for these enum values. Fixes cockroachdb#61814 Release note (bug fix): Fixed a bug whereby enums which have large numbers of values may cause unexpected errors when attempting to read from tables with columns using that enum.
ajwerner
force-pushed
the
ajwerner/fix-large-enums
branch
from
dad7087 to
18bad51
Compare
|
Updated the comment. bors r+ |
|
Build succeeded: |
This was referenced Mar 18, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The optimizer generates check constraints for enums. It does so by
writing these constraints as physical values. Unfortunately the way
we serialized these physical values was bogus if the enum's physical
value was more than one byte long. The reason was because of a difference
between string literal and byte string literals and their use of
\x.This fixes that by using hex byte string literals for these enum
values.
Fixes #61814
Release note (bug fix): Fixed a bug whereby enums which have large numbers of
values may cause unexpected errors when attempting to read from tables with
columns using that enum.