Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

tracing: lock around testing knobs #62095

Merged

Conversation

irfansharif
Copy link
Contributor

Fixes #61393. There was a race condition in our tests by not doing so.

Release note: None

Fixes cockroachdb#61393. There was a race condition in our tests by not doing so.

Release note: None
@irfansharif irfansharif requested review from tbg and a team March 16, 2021 17:18
@cockroach-teamcity
Copy link
Member

This change is Reviewable

@irfansharif
Copy link
Contributor Author

bors r+

@craig
Copy link
Contributor

craig bot commented Mar 17, 2021

Build succeeded:

@craig craig bot merged commit 2c5a676 into cockroachdb:master Mar 17, 2021
@irfansharif irfansharif deleted the 210316.deflake-TestDBAddSSTable branch March 17, 2021 23:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

kv/kvserver/batcheval: TestDBAddSSTable failed
3 participants