Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

release-21.1: sql: set locality to GLOBAL for materialized views #62194

Merged
merged 2 commits into from
Mar 18, 2021

Conversation

otan
Copy link
Contributor

@otan otan commented Mar 18, 2021

Backport 2/2 commits from #62122.

/cc @cockroachdb/release


Only last two commits matter.
See individual commits for details.

Refs: #61382

@otan otan requested review from ajstorm and a team March 18, 2021 04:52
@cockroach-teamcity
Copy link
Member

This change is Reviewable

@otan
Copy link
Contributor Author

otan commented Mar 18, 2021

ah i need @arulajmani to backport #61585

@ajstorm ajstorm self-requested a review March 18, 2021 12:05
Copy link
Collaborator

@ajstorm ajstorm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed 3 of 3 files at r1.
Reviewable status: :shipit: complete! 0 of 0 LGTMs obtained (waiting on @ajstorm)

@arulajmani
Copy link
Collaborator

ah i need @arulajmani to backport #61585

I re-triggered the build for you after my backport merged.

Release note (sql change): Materialized views in multi-region databases
will now have a GLOBAL locality.
Release note (sql change): Materialized views which are in a database
before the first ADD REGION will become GLOBAL on ADD REGION, in line
with the behavior of CREATE MATERIALIZED VIEW on a multi-region
database.
@otan
Copy link
Contributor Author

otan commented Mar 18, 2021

have to rebase manually in backport branches for that to work...

this ain't bors :P

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants