release-21.1: sql: Don't require override for multiple MR abstractions in a transaction #62518
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This change is |
…tion Previously, we required override_multi_region_zone_config to be specified if multiple add/drop region operations were included in a single transaction. This was due to the fact that the RegionConfig would get updated as part of the first operation, but the zone configurations to which we were comparing were not updated until the transaction committed. This issue was fixed in part by cockroachdb#62200, but this PR finishes the job by creating a function which synthesizes a zone configuration which presents the state of the RegionConfig at the beginning of the transaction. Release note: None
ajstorm
force-pushed
the
backport21.1-62354
branch
from
9eb537f
to
2f0af41
Compare
arulajmani
approved these changes
Mar 24, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Backport 1/1 commits from #62354.
/cc @cockroachdb/release
Previously, we required override_multi_region_zone_config to be
specified if multiple add/drop region operations were included in a
single transaction. This was due to the fact that the RegionConfig
would get updated as part of the first operation, but the zone
configurations to which we were comparing were not updated until the
transaction committed. This issue was fixed in part by #62200, but this
PR finishes the job by creating a function which synthesizes a zone
configuration which presents the state of the RegionConfig at the
beginning of the transaction.
Resolves: #61551
Release note: None