kvserver: repro branch for restore2tb snapshots #63784
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
tbg
commented
Apr 16, 2021
tbg
commented
- status quo attempt
- cli: walk directories in debug merge-logs
- cli: default program-filter for merge-logs to match everything
- fatal on MsgApp-induced split
This is a UX improvement. Instead of typing out `./cockroach debug merge-logs nodes/*/logs/*.log` (as one does for each `debug.zip` or roachtest investigation), you can now simply use `./cockroach debug merge-logs .`. Release note: None
The program filter is what matches the `<program>.<host>.<morestuff>.log` in the log files handed to `merge-logs`. The default is generally a reasonable choice but when you have an oddly named binary (does happen) merge-logs completely stops doing anything and time is wasted figuring out why. `merge-logs` is already very unlikely to pick up stray files since its default `file-pattern` matches the entire logging file format (it delegates only matching of `<program>` to the program-filter), so turning the program filter off by default seems right. Release note: None
And extra logging for timings. Release note: None
|
This change is |
This should make it easier to search to where things first started slowing down. Release note: None
Release note: None
Release note: None
Release note: None
Release note: None
Release note: None
Release note: None
Release note: None
Release note: None
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.