schemaexpr: fix data race in ProcessColumnSet #63921
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit fixes a data race introduced by my recent changes tracked under cockroachdb#63755, involving the generalized use of catalog.Column instead of descpb.ColumnDescriptor. Fixes cockroachdb#63907 Release note: None
|
This change is |
Closed
adityamaru
approved these changes
Apr 20, 2021
|
I'll bors as soon as CI passes. Should I forget or be struck by lightning or whatever please don't hesitate to do it in my stead. |
|
bors r+ |
|
Build failed (retrying...): |
|
bors r+ p=9999 single on I'm going to try and merge this in its own batch. |
|
Already running a review |
|
bors r- |
|
Canceled. |
|
bors r+ p=9999 single on |
|
Build succeeded: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit fixes a data race introduced by my recent changes tracked
under #63755, involving the generalized use of catalog.Column instead of
descpb.ColumnDescriptor.
Fixes #63907
Release note: None