rowenc: add value encoding for arrays of tuples #63996
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This change is |
knz
reviewed
Jun 5, 2021
There was a problem hiding this comment.
This looks nice, but probably needs a decode function too?
Reviewed 3 of 3 files at r1.
Reviewable status:complete! 0 of 0 LGTMs obtained (waiting on @rafiss)
rafiss
force-pushed
the
array-tuples
branch
2 times, most recently
from
289714c to
f27e031
Compare
Previously, queries that required an array of tuples to be encoded would fail. This could only happen if a distsql query required such a datum to be sent over the wire. This commit adds an encoding so such queries can succeed. Release note (bug fix): queries involving arrays of tuples will no longer spuriously fail due to an encoding error.
rafiss
force-pushed
the
array-tuples
branch
from
f27e031 to
0d86d80
Compare
rafiss
changed the title
rafiss
force-pushed
the
array-tuples
branch
from
0d86d80 to
009c1e3
Compare
rafiss
changed the title
rafiss
requested review from
otan,
yuzefovich and
a team
and removed request for
otan
yuzefovich
approved these changes
Sep 20, 2021
There was a problem hiding this comment.
re: the need for a decode function - looks like it is already in place.
Reviewed 5 of 5 files at r2.
Reviewable status:
|
tftr! bors r=yuzefovich |
|
This PR was included in a batch that was canceled, it will be automatically retried |
|
Build failed (retrying...): |
|
Build succeeded: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #32715
resurrecting an old PR #32871
Previously, queries that required an array of tuples to be encoded would
fail. This could only happen if a distsql query required such a datum to
be sent over the wire. This commit adds an encoding so such queries can
succeed.
A good followup task to do after this is #63995
Release note (bug fix): queries involving arrays of tuples will no
longer spuriously fail due to an encoding error.