sql: add http_addr column to sqlliveness table
#65720
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In order to implement fan out requests between SQL pods, we need a place to store their HTTP addresses so the pods can independently know how to talk to other tenants. This commit adds a column `http_addr` to the `system.sqlliveness` table and populates it with the HTTP listening address of the tenant pod on startup. Resolves cockroachdb#64475 Release note: None
|
This change is |
|
I am rather opposed to this. Maybe you should also be in the meeting we're having this afternoon about allocating instance IDs. Network addresses should be there and not here. Also, I think we're missing some over-arching design. These are really tightly linked concepts. cc @rimadeodhar @knz |
Gotcha. I'll attend. Thx for flagging. |
|
Pausing this for now pending decision on the Instance IDs |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In order to implement fan out requests between
SQL pods, we need a place to store their HTTP
addresses so the pods can independently know how
to talk to other tenants.
This commit adds a column
http_addrto thesystem.sqllivenesstable and populates it withthe HTTP listening address of the tenant pod on
startup.
Resolves #64475
Release note: None