Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

backupccl: stream writes of returned SSTs to remote files #66802

Merged
merged 3 commits into from
Jun 24, 2021

Conversation

dt
Copy link
Member

@dt dt commented Jun 23, 2021

This changes the backup processor to open remote files for writing and then write the content of returned SSTs as they are returned instead of writing to an in-memory SSTable and then flushing that to cloud storage later.

Release note: none.

@dt dt requested review from pbardea and a team June 23, 2021 21:36
@cockroach-teamcity
Copy link
Member

This change is Reviewable

pkg/ccl/backupccl/backup_processor.go Outdated Show resolved Hide resolved
dt added 3 commits June 24, 2021 04:02
This changes the backup processor to open remote files for writing and
then write the content of returned SSTs as they are retruned instead of
writing to an in-memory SSTable and then flushing that to cloud storage
later.

Release note: none.
@dt dt closed this Jun 24, 2021
@dt dt deleted the stream-returned branch June 24, 2021 04:03
@dt dt restored the stream-returned branch June 24, 2021 04:03
@dt dt reopened this Jun 24, 2021
@dt
Copy link
Member Author

dt commented Jun 24, 2021

TFTR!

bors r+

@craig
Copy link
Contributor

craig bot commented Jun 24, 2021

Build failed (retrying...):

@craig
Copy link
Contributor

craig bot commented Jun 24, 2021

Build succeeded:

@craig craig bot merged commit a1f969c into cockroachdb:master Jun 24, 2021
@dt dt deleted the stream-returned branch June 24, 2021 13:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants