sql/schemachanger: reorder args on Build, clone nodes, minor renaming

[ajwerner]

Release note: None

[cockroach-teamcity]

This change is 

[fqazi]

Reviewed 9 of 9 files at r1.
Reviewable status: complete! 0 of 0 LGTMs obtained (waiting on @ajwerner)

[fqazi]

Reviewed 17 of 17 files at r2, 12 of 12 files at r3.
Reviewable status: complete! 0 of 0 LGTMs obtained (waiting on @ajwerner)

---

pkg/sql/schemachanger/scbuild/builder.go, line 67 at r3 (raw file):

	// outputNodes contains the internal state when building targets for an individual
	// statement.
	outputNodes scpb.State

Nit: Do we want to rename these to outputState?

---

pkg/sql/schemachanger/scbuild/builder.go, line 117 at r3 (raw file):

func Build(
	ctx context.Context, dependencies Dependencies, initial scpb.State, n tree.Statement,
) (outputNodes scpb.State, err error) {

Nit: Similar here

---

pkg/sql/schemachanger/scbuild/builder_test.go, line 97 at r3 (raw file):

				stmts, err := parser.Parse(d.Input)
				require.NoError(t, err)
				var outputNodes scpb.State

Nit: rename

---

pkg/sql/schemachanger/scplan/plan_test.go, line 97 at r3 (raw file):

				stmts, err := parser.Parse(d.Input)
				require.NoError(t, err)
				var outputNodes scpb.State

Nit: outputState?

[fqazi]

Reviewed 2 of 2 files at r4.
Reviewable status: complete! 0 of 0 LGTMs obtained (waiting on @ajwerner)

[ajwerner]

bors r+

[craig]

Build failed (retrying...):

• GitHub CI (Cockroach)

[ajwerner]

bors r-

[craig]

Canceled.

[ajwerner]

bors r=fqazi

[craig]

Build succeeded:

• GitHub CI (Cockroach)