sql: store plan as jsonb in system.statement_statistics #67331
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Previously, we store statement plan as a byte blob column in system.statement_statistics. As of cockroachdb#65782 we now support JSON encoding for the plan. This commit change the column type for plan from BYTES to JSONB in system.statement_statistics. Release note (sql change): using JSONB to store statement plan instead of BYTES in system.statement_statistics.
|
This change is |
|
cc: @kevin-v-ngo |
maryliag
approved these changes
Jul 8, 2021
complete! 1 of 0 LGTMs obtained
|
bors r+ |
|
Build failed (retrying...): |
|
bors r+ |
|
Already running a review |
|
Build failed (retrying...): |
|
Build failed (retrying...): |
|
bors r- 🚨 bors is busted 🚨 |
|
Canceled. |
|
bors r=maryliag |
|
This PR was included in a batch that was canceled, it will be automatically retried |
|
Build failed (retrying...): |
|
Build succeeded: |
24 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously, we store statement plan as a byte blob column in
system.statement_statistics. As of #65782 we now support JSON
encoding for the plan.
This commit change the column type for plan from BYTES to JSONB
in system.statement_statistics.
Release note (sql change): using JSONB to store statement plan
instead of BYTES in system.statement_statistics.