Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

delegate: SHOW GRANTS ON TYPE works across DBs #68137

Merged
merged 1 commit into from
Jul 28, 2021

Conversation

rafiss
Copy link
Collaborator

@rafiss rafiss commented Jul 27, 2021

fixes #67512

Release note (bug fix): Previously, a SHOW GRANTS ON TYPE db.public.typ
command would not correctly show the grants if the current database was
not db. This is fixed now.

Release note (bug fix): Previously, a `SHOW GRANTS ON TYPE db.public.typ`
command would not correctly show the grants if the current database was
not `db`. This is fixed now.
@rafiss rafiss requested review from otan and a team July 27, 2021 22:58
@cockroach-teamcity
Copy link
Member

This change is Reviewable

@rafiss
Copy link
Collaborator Author

rafiss commented Jul 28, 2021

tftr!

bors r=RichardJCai

@craig
Copy link
Contributor

craig bot commented Jul 28, 2021

Build succeeded:

@craig craig bot merged commit c4702ef into cockroachdb:master Jul 28, 2021
@blathers-crl
Copy link

blathers-crl bot commented Jul 28, 2021

Encountered an error creating backports. Some common things that can go wrong:

  1. The backport branch might have already existed.
  2. There was a merge conflict.
  3. The backport branch contained merge commits.

You might need to create your backport manually using the backport tool.


error creating merge commit from 5506ea0 to blathers/backport-release-21.1-68137: POST https://api.github.com/repos/cockroachdb/cockroach/merges: 409 Merge conflict []

you may need to manually resolve merge conflicts with the backport tool.

Backport to branch 21.1.x failed. See errors above.


🦉 Hoot! I am a Blathers, a bot for CockroachDB. My owner is otan.

@rafiss rafiss deleted the fix-show-grants-on-type branch July 28, 2021 19:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

sql: SHOW GRANTS ON TYPE does not work for types not in the current database
3 participants