Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

kv: don't load applied index twice during Raft snapshot #68497

Merged

Commits on Aug 9, 2021

  1. kv: don't load applied index twice during Raft snapshot

    This was harmless, but it was also unnecessary and looked quite
    alarming. It would be a major problem if the Raft applied index stored
    in a `SnapshotMetadata` was ever incoherent with the applied state in
    the snapshot. However, we're reading from a consistent enging snapshot
    in `snapshot`, so the Raft applied index can't change. Still, better to
    avoid questions.
    
    The "members of the Range struct" comment was very stale, dating back
    to acc41dd.
    nvanbenschoten committed Aug 9, 2021
    Configuration menu
    Copy the full SHA
    60ce7be View commit details
    Browse the repository at this point in the history