Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ccl/serverccl: increase http client timeout in tests #69494

Conversation

dhartunian
Copy link
Collaborator

Tests run under stress would sometimes timeout waiting on HTTP calls to
return. This change creates a custom HTTP client with a 15s timeout. The
original client has a default 3s timeout.

Resolves #68879

Release justification: non-production code change

Release note: None

Tests run under stress would sometimes timeout waiting on HTTP calls to
return. This change creates a custom HTTP client with a 15s timeout. The
original client has a default 3s timeout.

Resolves cockroachdb#68879

Release justification: non-production code change

Release note: None
@dhartunian dhartunian requested a review from a team August 27, 2021 20:14
@cockroach-teamcity
Copy link
Member

This change is Reviewable

Copy link
Contributor

@abarganier abarganier left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:lgtm:

Reviewable status: :shipit: complete! 1 of 0 LGTMs obtained

@dhartunian
Copy link
Collaborator Author

bors r+abarganier

@craig
Copy link
Contributor

craig bot commented Aug 30, 2021

Build succeeded:

@craig craig bot merged commit cb6889c into cockroachdb:master Aug 30, 2021
@dhartunian dhartunian deleted the longer-http-client-timeout-on-tenant-grpc-test branch November 14, 2022 16:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

ccl/serverccl: TestTenantGRPCServices failed
3 participants