util: copy go1.16 ParseIP into separate file #69664
Conversation
|
This change is |
RichardJCai
force-pushed
the
copy_go1.16_ip_addr_parsing_08312021
branch
from
479963c
to
22779e8
Compare
| // ("2001:db8::68"), or IPv4-mapped IPv6 ("::ffff:192.0.2.1") form. | ||
| // If s is not a valid textual representation of an IP address, | ||
| // ParseIP returns nil. | ||
| func ParseIP(s string) IP { |
There was a problem hiding this comment.
should we make ParseIP / IPv4 private?
There was a problem hiding this comment.
Realized ParseIP has to be used in tree as well so that has to be exported.
Changed IPv4 to makeIPv4.
| @@ -0,0 +1,235 @@ | |||
| // Copyright 2009 The Go Authors. All rights reserved. | |||
There was a problem hiding this comment.
probably need to silence the linter on the copyright thing
make a comment that this is a copy from the v1.16 code & why this is needed
|
Take a look at https://github.com/cockroachdb/cockroach/blob/master/pkg/util/uuid/uuid.go to see an example of how to preserve the original copyright |
RichardJCai
force-pushed
the
copy_go1.16_ip_addr_parsing_08312021
branch
from
22779e8
to
1ba0487
Compare
go1.17 is changing how IPs are parsed, leading 0s will not be accepted. This change ensures that IP addresses with leading 0s are accepted (which is the case in Postgres) Release justification: only moved code out of go package to it's own file. Release note: None
RichardJCai
force-pushed
the
copy_go1.16_ip_addr_parsing_08312021
branch
from
1ba0487
to
f44ccb0
Compare
There was a problem hiding this comment.
Reviewed 2 of 3 files at r1, 3 of 3 files at r2, all commit messages.
Reviewable status:complete! 1 of 0 LGTMs obtained (waiting on @otan and @rafiss)
|
Thanks for the reviews! |
|
Build succeeded: |
go1.17 is changing how IPs are parsed, leading 0s will not be accepted.
This change ensures that IP addresses with leading 0s are accepted
(which is the case in Postgres)
Release justification: only moved code out of go package to it's own
file.
Release note: None