sql: drop database cascade can fail resolving schemas #69789
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixes: cockroachdb#69713 Previously, drop database cascade would drop the schema first, and then drop any objects under those schemas after. This was inadequate because as we look up any objects under the schemas, we may need to resolve types, which will may lead to a look up on the schema. If the schema is dropped then we will fail while resolving any types. To address this, this patch drops the objects under the schema first followed by the database. Release justification: Low risk bug fix for drop database cascade Release note (bug fix): Drop database cascade can fail while resolving a schema in a certain scenarios with the following error: "ERROR: error resolving referenced table ID <ID>: descriptor is being dropped"
|
This change is |
ajwerner
approved these changes
Sep 9, 2021
There was a problem hiding this comment.
Reviewed 2 of 2 files at r1, all commit messages.
Reviewable status:complete! 1 of 0 LGTMs obtained (waiting on @fqazi)
|
@ajwerner TFTR! |
|
bors r=ajwerner |
|
Build failed: |
|
bors r+ |
|
Build failed (retrying...): |
|
Build failed (retrying...): |
|
Build failed (retrying...): |
|
Build succeeded: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes: #69713
Previously, drop database cascade would drop the schema first,
and then drop any objects under those schemas after. This was
inadequate because as we look up any objects under the schemas,
we may need to resolve types, which will may lead to a look up
on the schema. If the schema is dropped then we will fail while
resolving any types. To address this, this patch drops the objects
under the schema first followed by the database.
Release justification: Low risk bug fix for drop database cascade
Release note (bug fix): Drop database cascade can fail while resolving
a schema in a certain scenarios with the following error:
"ERROR: error resolving referenced table ID : descriptor is
being dropped"