Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

sql: adjust recently added logging events for txn row count guardrails #69945

Merged
merged 2 commits into from
Sep 10, 2021
Merged

sql: adjust recently added logging events for txn row count guardrails #69945

merged 2 commits into from
Sep 10, 2021

Commits on Sep 9, 2021

  1. sql: adjust txn rows written/read guardrails a bit 

    Release note (ops change): the meaning of the recently introduced
`transaction_rows_written_err` and `transaction_rows_read_err` (as well
as the corresponding `_log` variables) have been adjusted a bit to
indicate the largest number of rows that is still allowed. In other
words, originally reaching the limit would result in an error, and now
only exceeding the limit would.

Release justification: low-risk adjustment to new functionality.
    @yuzefovich
    yuzefovich committed Sep 9, 2021
    Configuration menu
    Copy the full SHA
    a0f68a1 View commit details
    Browse the repository at this point in the history

  2. sql: adjust recently added logging events for txn row count guardrails 

    This commit refactors the recently introduced
`CommonTxnRowsLimitDetails` protobuf struct to make it more
user-friendly (since it is used for logging and errors). Namely, the
following changes are made:
- `Limit` is changed to `NumRows` making it easier to understand
- `ViolatesTxnRowsLimitErr` is removed since it is confusing
- `IsRead` is removed too since it is redundant (the types of logged
events contain the necessary "kind" information and this commit
extends the logic of errors to contain the "kind" info too) and is
confusing.

Additionally, we will no longer log twice if `_err` guardrail is reached
after `_log` was reached previously.

Release note: None (no release since this was introduced)

Release justification: an update to the new functionality.
    @yuzefovich
    yuzefovich committed Sep 9, 2021
    Configuration menu
    Copy the full SHA
    3460a19 View commit details
    Browse the repository at this point in the history