Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Shawn/protobuf #7

Merged
merged 4 commits into from
Feb 16, 2014
Merged

Shawn/protobuf #7

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
0b33fd9
Protobuf support - Makefile and README
Feb 15, 2014
e0f50b9
Pull in the api from the design doc
Feb 15, 2014
c1d0e99
Move files into /proto
Feb 15, 2014
bef894c
microsecs -> nono
Feb 16, 2014
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions proto/Makefile
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,5 @@
all:
protoc --go_out=. *.proto

clean:
rm *.go
13 changes: 13 additions & 0 deletions proto/README.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,13 @@
# Cockroach Protobuffer API

This defines the low-level key-value API

## Hacking

The Go build tools don't support code generation very well. The approach taken here is to commit the Go generated sources along side the .proto files. This is modeled after https://github.com/golang/groupcache/blob/master/groupcachepb/groupcache.pb.go by @bradfitz

To change the API, update the proto file, run make in this directory, commit both the proto and go files.

Other references to Go code generation:
* http://jteeuwen.nl/code/go/automatic_code_generation.html
* https://plus.google.com/u/0/105521491106709880714/posts/bnUmdCGgJKD
Loading